Fix the flaky logout test #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushpak1300
force-pushed
the
fix/logout_test
branch
from
2901b38 to
5feb26c
Compare
crynobone
reviewed
Sep 22, 2025
pushpak1300
changed the title
This was referenced Sep 22, 2025
crynobone
approved these changes
Sep 23, 2025
|
@crynobone starter kit PRs have been merged, can you verify tests should now pass and merge if so? |
|
Looks good now. |
crynobone
added a commit
that referenced
this pull request
Sep 29, 2025
* Optimize CI workflows by adding caching for Composer and Playwright * Update CI workflows to use actions/checkout@v5 * Fix the flaky logout test (#3) * Fix the logout test to use XPath for username click * Update tests/Browser/Auth/AuthenticationTest.php * Use data-test attribute instead of xpath --------- Co-authored-by: Mior Muhammad Zaki <[email protected]> --------- Co-authored-by: Mior Muhammad Zaki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Logout test is flaky. This MR switches to using the data-test approach to click on the element, which works more reliably.